Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename io/dynamic_io_new.hpp to io/dynamic.hpp #189

Closed
mloskot opened this issue Dec 12, 2018 · 0 comments · Fixed by #653
Closed

Rename io/dynamic_io_new.hpp to io/dynamic.hpp #189

mloskot opened this issue Dec 12, 2018 · 0 comments · Fixed by #653
Labels
cat/refactoring Any nonfunctional changes

Comments

@mloskot
Copy link
Member

mloskot commented Dec 12, 2018

(/cc @stefanseefeld @chhenning)

@sdebionne suggested in #185 (comment)

should io/dynamic_io_new.hpp be io/dynamic_io.hpp really?

I think it is a valid suggestion since the current name is unnecessarily complex, may be confusing:

  • new is obscure: as in new implementation or as in new-allocated dynamic memory, etc.
  • io is redundant, since all core IO headers live in dedicated directory

I'd expect renaming it is safe from compatibility point, majority of the file is boost:gil::detail namespace and just this one lives outside

/// \brief Within the any_image, constructs an image with the given dimensions
/// and a type that satisfies the given predicate
template <typename Images,typename Pred>
inline bool construct_matched(any_image<Images>& im,Pred pred) {
return detail::construct_matched_t<mpl::size<Images>::value>::apply(im,pred);
}

but possibly it should live in the detail as well.

Comments?

@mloskot mloskot added cat/enhancement Improvements, but not fixes addressing identified bugs cat/refactoring Any nonfunctional changes labels Dec 12, 2018
@mloskot mloskot added the status/need-feedback Asking for more details about the problem label Jan 11, 2019
@mloskot mloskot removed cat/enhancement Improvements, but not fixes addressing identified bugs status/need-feedback Asking for more details about the problem labels Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat/refactoring Any nonfunctional changes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant