Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inspect: violation of min/max guidelines in image_processing/threshold.hpp #376

Closed
mloskot opened this issue Aug 8, 2019 · 0 comments · Fixed by #378
Closed

inspect: violation of min/max guidelines in image_processing/threshold.hpp #376

mloskot opened this issue Aug 8, 2019 · 0 comments · Fixed by #378
Assignees
@miralshah365
Labels
cat/bug But reports and bug fixes core boost/gil

Comments

@mloskot
Copy link
Member

mloskot commented Aug 8, 2019

Actual behavior

The Boost inspect tool reports the following violations:

/mnt/d/boost.wsl/libs/gil$ inspect -text
Boost Inspection Report
Run Date: 19:46:33 UTC, Thursday 08 August 2019
...
Details:
  *M* uses of min or max that have not been protected from the min/max macros, or unallowed #undef-s
...
|include|
  include/boost/gil/image_processing/threshold.hpp:
    *M* violation of Boost min/max guidelines on line 156
    *M* violation of Boost min/max guidelines on line 233
    *M* violation of Boost min/max guidelines on line 234
    *M* violation of Boost min/max guidelines on line 448

Expected behavior

The files should not upset the inspect tool :-)
@mloskot mloskot added cat/bug But reports and bug fixes core boost/gil labels Aug 8, 2019
miralshah365 added a commit to miralshah365/gil that referenced this issue Aug 9, 2019
@miralshah365
Guidelines violations resolved.
2f0bc14 
New copyright holder name added in required files

closes boostorg#376
@miralshah365 miralshah365 mentioned this issue Aug 9, 2019
Merged
2 tasks
mloskot pushed a commit that referenced this issue Aug 9, 2019
@miralshah365 @mloskot
Fix Boost guidelines violations (#378)
f6c502b 
Add copyright notice.
Add protection from the min/max macro.

Closes #376
@mloskot mloskot mentioned this issue Aug 20, 2019
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miralshah365 miralshah365

Labels
cat/bug But reports and bug fixes core boost/gil
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Boost guidelines violations miralshah365/gil
2 participants
@mloskot @miralshah365