Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove C++11 build jobs from CI #696

Closed
mloskot opened this issue Jun 27, 2022 · 2 comments · Fixed by #698
Closed

Remove C++11 build jobs from CI #696

mloskot opened this issue Jun 27, 2022 · 2 comments · Fixed by #698
Labels
test New tests development or missing tests issues, no new functionality
Milestone
Boost 1.80

Comments

@mloskot
Copy link
Member

mloskot commented Jun 27, 2022

For Boost 1.80, we have announced the switch from C++11 to C++14 with Boost 1.80.

This should be followed with removal of C++11 builds from our CI-s.

Yes, GIL may still build as C++11 for a while after the release of Boost 1.80, but keeping those jobs will be confusing.
Removing them will also speed up our CI operations.
@mloskot mloskot added the test New tests development or missing tests issues, no new functionality label Jun 27, 2022
@mloskot mloskot added this to the Boost 1.80 milestone Jun 27, 2022
@marco-langer
Copy link
Contributor

Shouldn't this be on the 1.81 milestone then?

Yes, GIL may still build as C++11 for a while after the release of Boost 1.80

Bold to assume that, I thought to get rid of all std::bind's as soon as we hit 1.80, replace them with generic lambdas and never look back ;)

mloskot added a commit to mloskot/gil that referenced this issue Jun 27, 2022
@mloskot
ci: Remove C++11 build jobs after C++14 switch
a09ad81 
Closes boostorg#696
@mloskot
Copy link
Member Author

mloskot commented Jun 27, 2022

Why? If Boost.GIL 1.80 is said and set to require C++14 or later, then what is the reason to keep anything C++11?

@mloskot mloskot mentioned this issue Jun 27, 2022
Merged
1 task
mloskot added a commit to mloskot/gil that referenced this issue Jun 27, 2022
@mloskot
build: Update CMAKE_CXX_STANDARD from 11 to 14
103f4d3 
Follow-up to PR boostorg#677 and Issue boostorg#696
mloskot added a commit to mloskot/gil that referenced this issue Jun 27, 2022
@mloskot
build: Fix CMake source file extensions must be explicit
5db892b 
Follow-up to boostorg#677
Related to boostorg#696
@mloskot mloskot mentioned this issue Jun 27, 2022
Merged
1 task
mloskot added a commit that referenced this issue Jun 27, 2022
@mloskot
ci: Remove C++11 build jobs after C++14 switch (#698)
27826a7 
* build: test/Jamfile now check for cxx14_constepxr

Closes #696
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test New tests development or missing tests issues, no new functionality
Projects
None yet
Milestone
Boost 1.80
Development

Successfully merging a pull request may close this issue.

ci: Remove C++11 build jobs after C++14 switch mloskot/gil
2 participants
@mloskot @marco-langer