-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Boost.Variant instead of GIL's own variant implementation. #231
Conversation
8813b31
to
ff2aed2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. No new warnings seem to appear (at least on Travis), that's good.
There is a trade-off obviously and GIL now directly requires Boost.Variant, but I think the benefits outweight that extra dep.
@sdebionne Thanks for the contribution!
If this is merged, I think it should close #131 as fixed :-)
Let's see what @stefanseefeld says
I made mistake while editing squashed commits message, this should read
I don't feel comfy about amending the pushed commit. Sorry about that. |
@stefanseefeld, @sdebionne I think the only executable compiled with any |
|
@stefanseefeld Right. Let's take it for now as enough :) |
Tentatively trying to fix #131 and working around GCC bug 87107
Since Boost.Variant already supports lambda visitors, this makes #227 probably unnecessary.
References
#131
#227
Tasklist