Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added definition of gaussian adaptive threshold #379

Merged
merged 1 commit into from
Aug 19, 2019

Conversation

miralshah365
Copy link
Contributor

@miralshah365 miralshah365 commented Aug 11, 2019

Description

New threshold adaptive method added.

This method allows the user to set threshold values according to neighbors. The threshold value is found by calculating the gaussian value of all the neighbors including pixel itself. This gaussian value is then treated as a threshold and the binary threshold is performed.

References

closes #316

Tasklist

@miralshah365 miralshah365 added this to the Boost 1.72+ milestone Aug 11, 2019
@miralshah365 miralshah365 self-assigned this Aug 11, 2019
Copy link
Member

@mloskot mloskot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miralshah365 Are you planning to add any test cases?

This can be merged as it is, but either the description states that a test is coming soon as separate PR or a test is added to this PR.

@mloskot mloskot marked this pull request as ready for review August 18, 2019 15:03
@mloskot mloskot added the cat/feature New feature or functionality label Aug 18, 2019
@miralshah365
Copy link
Contributor Author

miralshah365 commented Aug 19, 2019

@mloskot I will send a separate PR to add tests for both the adaptive thresholds

Copy link
Member

@mloskot mloskot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miralshah365 Feel free to merge

@miralshah365 miralshah365 merged commit 5f612cc into boostorg:develop Aug 19, 2019
@marco-langer
Copy link
Contributor

@mloskot The sudoku threshold example image in this PR is the same as the one used in the official OpenCV thresholding tutorial.

Do you think this is a problem regarding copyright?

@mloskot
Copy link
Member

mloskot commented Jun 29, 2022

@marco-langer This is a very good question which I have kind of avoided to address for long time planning to

Then, boostorg/gil would be just a client/user of collection(s) of test images.

For now, I don't know what is the answer to your question.
Possibly, test images used by OpenCV have also external provenance ¯_(ツ)_/¯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat/feature New feature or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[gsoc2019] Implement adaptive gaussian thresholding
3 participants