-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added definition of gaussian adaptive threshold #379
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@miralshah365 Are you planning to add any test cases?
This can be merged as it is, but either the description states that a test is coming soon as separate PR or a test is added to this PR.
@mloskot I will send a separate PR to add tests for both the adaptive thresholds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@miralshah365 Feel free to merge
@mloskot The sudoku threshold example image in this PR is the same as the one used in the official OpenCV thresholding tutorial. Do you think this is a problem regarding copyright? |
@marco-langer This is a very good question which I have kind of avoided to address for long time planning to
Then, For now, I don't know what is the answer to your question. |
Description
New threshold adaptive method added.
This method allows the user to set threshold values according to neighbors. The threshold value is found by calculating the gaussian value of all the neighbors including pixel itself. This gaussian value is then treated as a threshold and the binary threshold is performed.
References
closes #316
Tasklist