Replace Boost.MPL with Boost.MP11 in promote_integral.hpp #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mloskot
added
the
cat/enhancement
|
@codejaeger Is this ready to review? |
codejaeger
force-pushed
the
replace_mpl_with_mp11
branch
from
bf22c54 to
8f8ea7d
Compare
|
@mloskot To give an overview of what changes I made and what not:
Did not change -
I think it is ready for review. Thanks. |
mloskot
requested changes
Mar 9, 2020
There was a problem hiding this comment.
@codejaeger This looks good. Could you just address parameter renaming?
mloskot
approved these changes
Mar 10, 2020
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to replace all occurrences of Boost.mpl's meta functions with equivalents from Boost.mp11 as mentioned in #280. I have tried to make minimal number of changes to the source code while using only functionality from Boost.mp11 . I have also tried using other ways to do the replacement using mp_find_if or mp_cond from the mp11 docs but this PR proposes using mp_rest to recurse over the type list.
References
https://www.boost.org/doc/libs/develop/libs/mp11/doc/html/mp11.html#mp_restl
https://www.boost.org/doc/libs/develop/libs/mp11/doc/html/mp11.html#mp_find_ifl_p
https://www.boost.org/doc/libs/develop/libs/mp11/doc/html/mp11.html#mp_condc_t_r
Tasklist
Add test case(s)Check existing tests pass.