Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Boost.Test with Boost.LightweightTest in test/ #459

Merged

Conversation

mloskot
Copy link
Member

@mloskot mloskot commented Mar 21, 2020

Description

Motivation is to:

  • use single, simpler and light test framework
  • eliminate dependency on libraries like Boost.MPL
  • achieve faster compilation times for CI builds (20% seems feasible)
  • have test programs easy to run and debug
  • avoid macros

Split some of large or all-in-one test .cpp files into smaller ones.
Improve test/extension/io/Jamfile with separate format-specific targets.
Remove outdated FIXME-s for bugs that have been already fixed.
Fix off-by-one bug in test/core/test_fixture.hpp generators.
Minor corrections and tidying up.

Add missing test assertions to numeric extension tests.

References

Tasklist

@mloskot mloskot added cat/enhancement Improvements, but not fixes addressing identified bugs cat/refactoring Any nonfunctional changes test New tests development or missing tests issues, no new functionality labels Mar 21, 2020
@mloskot mloskot self-assigned this Mar 21, 2020
@mloskot mloskot added the status/work-in-progress Do NOT merge yet until this label has been removed! label Mar 21, 2020
@mloskot mloskot force-pushed the ml/replace-boost-test-with-boost-lt branch from 29a220a to 7b6a42f Compare March 21, 2020 19:14
Motivation is to:
- use on simpler and light test framework,
- eliminate dependency on libraries like Boost.MPL,
- achieve faster compilation times for CI builds (20% seems feasible)
- have test programs easy to run and debug
- avoid macros

Remove outdated FIXME-s for bugs that have been already fixed.
Fix off-by-one bug in test/core/test_fixture.hpp generators.
Minor corrections and tidying up.

Add missing test assertions to numeric extension tests.
Fixes boostorg#458
@mloskot mloskot removed the status/work-in-progress Do NOT merge yet until this label has been removed! label Mar 21, 2020
@mloskot mloskot added this to the Boost 1.73 milestone Mar 21, 2020
@mloskot mloskot merged commit dda885e into boostorg:develop Mar 21, 2020
@mloskot mloskot deleted the ml/replace-boost-test-with-boost-lt branch March 21, 2020 21:53
mloskot added a commit to mloskot/gil that referenced this pull request Mar 22, 2020
Move test sources to format-specific directories.
Add missing `#include`-s with standard library headers.
Minor corrections and tidying up.

Continues boostorg#459
Closes boostorg#461
mloskot added a commit to mloskot/gil that referenced this pull request Mar 22, 2020
Move test sources to format-specific directories.
Add missing `#include`-s with standard library headers.
Minor corrections and tidying up.

Continues boostorg#459
Closes boostorg#461
mloskot added a commit to mloskot/gil that referenced this pull request Mar 22, 2020
Move test sources to format-specific directories.
Add missing `#include`-s with standard library headers.
Minor corrections and tidying up.

Continues boostorg#459
Closes boostorg#461
mloskot added a commit to mloskot/gil that referenced this pull request Mar 22, 2020
Move test sources to format-specific directories.
Add missing `#include`-s with standard library headers.
Minor corrections and tidying up.

Continues boostorg#459
Closes boostorg#461
mloskot added a commit to mloskot/gil that referenced this pull request Mar 23, 2020
Move test sources to format-specific directories.
Add FIXME and TODO comments about issues discovered while building the format-specific tests.
Add missing `#include`-s with standard library headers.
Apply minor corrections and tidying up.

Continues boostorg#459
Closes boostorg#461
mloskot added a commit to mloskot/gil that referenced this pull request Mar 23, 2020
Move test sources to format-specific directories.
Add FIXME and TODO comments about issues discovered while building the format-specific tests.
Add missing `#include`-s with standard library headers.
Apply minor corrections and tidying up.

Continues boostorg#459
Closes boostorg#461
mloskot added a commit that referenced this pull request Mar 24, 2020
)

Move test sources to format-specific directories.
Add FIXME and TODO comments about issues discovered while building the format-specific tests.
Add missing `#include`-s with standard library headers.
Apply minor corrections and tidying up.

Continues #459
Closes #461
mloskot added a commit to mloskot/gil that referenced this pull request Mar 24, 2020
mloskot added a commit to mloskot/gil that referenced this pull request Mar 24, 2020
mloskot added a commit that referenced this pull request Mar 24, 2020
mloskot added a commit to mloskot/gil that referenced this pull request Mar 30, 2020
* origin/develop: (70 commits)
  Always build test/extension/io/targa tests for images hosted in source tree
  Simplify test/extension/io/CMakeLists.txt
  Remove detailed C++/compiler/test matrix from README.md
  Add utilities to make some basic types printable for BOOST_TEST_EQ [ci skip]
  Update release notes   [ci skip]
  Update release notes [ci skip]
  Add good-enough .clang-format to example/clang-format/
  Catch and report exceptions thrown from test/extension//simple test
  Fix initialization order of scanline_read_iterator members (-Wreorder)
  Remove compile-time configuration macros from Jamfile
  Catch and report exceptions thrown from test/extension/io/bmp tests
  Always build test/extension/io/bmp//make for images hosted in source tree
  Always build test/extension/io/bmp tests for images hosted in source tree
  Always build test/extension/io//simple if format libraries are available (boostorg#467)
  Clean up CI and CMake from Boost.Test and Boost.System remains (boostorg#465)
  Removed extension/dynamic_image/reduce.hpp as unused (boostorg#466)
  Replace Boost.Test with Boost.LightweightTest in test/extension/io (boostorg#464)
  Fix -Wunused-variable warning
  AzP: Switch to MacOS 10.14  [skip appveyor]
  Replace Boost.Test with Boost.LightweightTest in test/ (boostorg#459)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat/enhancement Improvements, but not fixes addressing identified bugs cat/refactoring Any nonfunctional changes test New tests development or missing tests issues, no new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some toolbox tests do not test anything
1 participant