Remove unnecessary numeric_cast in hsv.hpp #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both temp_red and max_color are float32_t so the result of the subraction already has the right type. This should also remove the only dependency on Boost.NumericConversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes an unnecessary numeric_cast in include\boost\gil\extension\toolbox\color_spaces\hsv.hpp that casts from float32_t to float32_t.
This removes the only dependency on Boost.NumericConversion I could find
References
https://cpplang.slack.com/archives/C27KZLB0X/p1605793604490300
Tasklist