Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and update includes in boost/gil.hpp #559

Merged
merged 3 commits into from
Feb 4, 2021

Conversation

Siddharth1010
Copy link
Contributor

Description

Fixes #553 : Added missing headers and sorted them.

@Siddharth1010
Copy link
Contributor Author

@mloskot I have created a separate PR as I was facing an error while fetching upstream. Is this okay?

@mloskot
Copy link
Member

mloskot commented Feb 3, 2021

Better would be to learn how to deal with the error. It's a common situation when using git.

@Siddharth1010
Copy link
Contributor Author

Yes you're right. I should have done that. But unfortunately there's no option to reopen the PR as I cloned the repo again.

@mloskot
Copy link
Member

mloskot commented Feb 4, 2021

I think we are hitting the time limit on AppVeyor, so we can ignore the build failure there.

@mloskot mloskot added the cat/annoyance Not a bug, not a feature, but something that should be improved label Feb 4, 2021
@mloskot mloskot added this to the Boost 1.76+ milestone Feb 4, 2021
@Siddharth1010
Copy link
Contributor Author

Yes it seems to have failed again. Is there anything else I need to change?

Copy link
Member

@mloskot mloskot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mloskot mloskot merged commit 8337f47 into boostorg:develop Feb 4, 2021
@Siddharth1010
Copy link
Contributor Author

Thank you :)

meshtag pushed a commit to meshtag/gil that referenced this pull request Mar 17, 2021
Fixes boostorg#555

Co-authored-by: Mateusz Łoskot <mateusz@loskot.net>
meshtag pushed a commit to meshtag/gil that referenced this pull request Apr 21, 2021
Fixes boostorg#555

Co-authored-by: Mateusz Łoskot <mateusz@loskot.net>
meshtag pushed a commit to meshtag/gil that referenced this pull request Apr 22, 2021
Fixes boostorg#555

Co-authored-by: Mateusz Łoskot <mateusz@loskot.net>
@mloskot mloskot mentioned this pull request May 12, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat/annoyance Not a bug, not a feature, but something that should be improved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review and update includes in boost/gil.hpp
2 participants