Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port TuttleOFX extension : pattern #581

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from

Conversation

meshtag
Copy link
Member

@meshtag meshtag commented Mar 17, 2021

Description

This pull request intends to port pattern extension from TuttleOFX to Gil as mentioned in #449 .

I have tried not to change anything significant in actual extension code. However, I have reformatted test cases completely in order to align them with current practices followed by Gil.

Tasklist

  • Add test case(s)
  • Ensure all CI builds pass
  • Review and approve

@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #581 (1284963) into develop (bbdce36) will increase coverage by 0.25%.
The diff coverage is 92.85%.

@@             Coverage Diff             @@
##           develop     #581      +/-   ##
===========================================
+ Coverage    78.72%   78.98%   +0.25%     
===========================================
  Files          118      119       +1     
  Lines         5034     5048      +14     
===========================================
+ Hits          3963     3987      +24     
+ Misses        1071     1061      -10     

@mloskot mloskot added ext/toolbox boost/gil/extension/toolbox/ cat/feature New feature or functionality labels Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat/feature New feature or functionality ext/toolbox boost/gil/extension/toolbox/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants