Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#605 Removed deprecated.hpp #627

Merged

Conversation

yogsothoth
Copy link
Contributor

@yogsothoth yogsothoth commented Oct 29, 2021

Description

Remove /include/boost/gil/deprecated.hpp
Remove include of deprecated.hpp from include/boost/gil.hpp

References

See Issue #605

Note: PR #625 was proposed but not merged, as CI pipelines broke. The corresponding build logs seem to have been cleaned up; this PR should trigger a new build and produce new logs to inspect.

Environment:

  • clang 11.0.1
  • FreeBSD 13.0-RELEASE-p4
  • x86_64

Tasklist

  • Remove file include/boost/gil/deprecated.hpp
  • Remove include from include/boost/gil.hpp
  • Compile and run all tests with b2 (cxxstd=11,14,17,2a)
  • Compare build output with a run w/deprecated.hpp
  • Ensure all CI builds pass
  • Review and approve

@yogsothoth
Copy link
Contributor Author

The CI builds passed for:

  • win2016_vs2017_cxx14_cmake
  • win2016_vs2017_cxx17_cmake
  • macos1014_xcode11_cmake

However, two pipelines need attention:

  • ubuntu_1604_gcc6_cxx14_cmake
  • ubuntu_1604_gcc8_cxx14_cmake

The image seems to be missing:
`##[warning]An image label with the label ubuntu-16.04 does not exist.

,##[error]The remote provider was unable to process the request.`

(the builds were automatically cancelled here)

Not sure how I can help here?

@meshtag
Copy link
Member

meshtag commented Oct 29, 2021

Mentioning this for further info. (/cc @mloskot @lpranam @simmplecoder)

Copy link
Member

@lpranam lpranam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me :)

@lpranam lpranam mentioned this pull request Apr 6, 2022
Copy link
Member

@mloskot mloskot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite the CI is still not working well, let's merge.

@mloskot mloskot added this to the Boost 1.78+ milestone Apr 6, 2022
@mloskot mloskot added the core boost/gil label Apr 6, 2022
@mloskot mloskot merged commit 63f5837 into boostorg:develop Apr 6, 2022
@mloskot mloskot linked an issue Apr 21, 2022 that may be closed by this pull request
@mloskot mloskot mentioned this pull request May 12, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core boost/gil
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated.hpp added in 2007
4 participants