-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: re-allow devicen_t with two color components #654
fix: re-allow devicen_t with two color components #654
Conversation
devicen_t<2> was possible in Boost 1.71, but broke in Boost 1.72. Now it's possible to use it again. Fixes boostorg#519.
Despite some jobs fail (w/ older clang and GCC 8 cxxstd=17) I'm happy to merge it. Thanks! |
Thanks for merging it. 👍 The jobs for GCC 8 and older Clang variants also failed before that, see e. g. here: https://github.com/boostorg/gil/actions/runs/2321824140 That's why I mentioned that those Clang jobs should possibly be removed in #640 (comment):
If removal of those jobs is not an option, then maybe someone should look into how to build with Clang 3.x on other, still available runners. |
We have seen similar failures where a particular compiler version with particular C+ version and build configuration variant generates segfaulting binary or it fails with internal compiler error. Either GIL stretches some compilers to the limits or there is a subtle bug that is hard to reproduce :-) So, I don't mind disabling such peculiar CI jobs. We are not testing compilers after all. UPDATE: Done in 4ad824e |
Description
devicen_t<2> was possible in Boost 1.71, but broke in Boost 1.72.
Now it's possible to use it again.
Since there was no real need to disallow it in the first place, I adjusted the
static_assert
which prevented it to allow two components, too.References
Fixes #519.
See that issue for more information.
Tasklist