Fixed io extension build error #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error was due to missing dynamic.hpp header that contained dynamic_io_fnobj. Adding the header back in to write.hpp headers of io extensions fixed the problem.
sdebionne
added
cat/bug
sdebionne
approved these changes
May 13, 2022
And, I believe I did run local build too! Mystery :) |
|
thanks for the fix on my PR! I'll join the club of surprised people that the bug was not caught in my own test run :-) |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The error was due to missing dynamic.hpp header that contained dynamic_io_fnobj. Adding the header back in to write.hpp headers of io extensions fixed the problem.
References
#653 (comment).
Tasklist
Add test case(s)N/A (run build and tests locally, all passed)