Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Move GSoC 2020 features to extension #673

Merged
merged 8 commits into from
Jun 3, 2022
Merged

refactor: Move GSoC 2020 features to extension #673

merged 8 commits into from
Jun 3, 2022

Conversation

simmplecoder
Copy link
Contributor

@simmplecoder simmplecoder commented May 17, 2022 •
edited by mloskot
Loading

Description

Moves functionality implemented in GSoC 2020 by Olzhas into extension and improves documentation with some fiixups needed.

References

Discussion link.

Tasklist

  • Move rasterization to extension
  • Move Hough transform to extension
  • Move anisotropic diffusion into extension
  • [ ] Add release notes Were already added
  • Ensure all CI builds pass
  • Review and approve

@simmplecoder
Copy link
Contributor Author

This commit is not complete, but is ready to be merged if needed. I will keep adding on it by strict improvements (so that each commit would still leave it in mergeable state).

@mloskot mloskot changed the title Gsoc 2020 fixup refactor: Move GSoC 2002 rasterization features to extension May 17, 2022
@mloskot mloskot added the cat/refactoring Any nonfunctional changes label May 17, 2022
@mloskot mloskot added this to the Boost 1.80 milestone May 17, 2022
@mloskot mloskot changed the title refactor: Move GSoC 2002 rasterization features to extension refactor: Move GSoC 2020 features to extension May 17, 2022
@simmplecoder simmplecoder force-pushed the gsoc_2020_fixup branch 2 times, most recently from ebe294e to de02c67 Compare May 26, 2022 19:50
mloskot
mloskot requested changes May 27, 2022
View reviewed changes
Copy link
Member

@mloskot mloskot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Jamfiles need to be corrected.

test/extension/rasterization/Jamfile Outdated Show resolved Hide resolved
test/extension/image_processing/Jamfile Outdated Show resolved Hide resolved
@mloskot mloskot added ext/rasterization boost/gil/extension/rasterization ext/image_processing boost/gil/extension/image_processing labels May 27, 2022
@simmplecoder
Fix Hough transform and move rasterization
bab2a37 
Hough line transform had incorrect
rounding which lead to misleading message
@simmplecoder
In depth explanation for Hough line
f87ee56 
Added in depth explanation for
Hough line transform in the
associated markdown file
@simmplecoder
Change "" includes into <>
cc39f1a
@simmplecoder
Move diffusion and Hough transform
48d7ebf 
Move anisotropic diffusion and
Hough transform into extension.
Adjust tests and cmakelists
@simmplecoder
Edit Jamfile to new layout
b962a6a
@simmplecoder
Add compile statements to Jamfile
76dcca8
@simmplecoder
Remove migrated files
3965f2a
@marco-langer
Copy link
Contributor

marco-langer commented Jun 2, 2022 •
edited
Loading

Some refactor suggestions:

  • line.hpp is missing include guards.
  • d_first in line.hpp and circle.hpp models OutputIterator category and not RandomAccessIterator category
  • mixing of east and west const in line.hpp
  • trailing return types
  • namespace boost { namespace gil { should be a one-liner in line.hpp

@mloskot
Copy link
Member

mloskot commented Jun 2, 2022

Thank you @marco-langer
AFAIK, @simmplecoder is preparing to move home at the moment.

I think we should merge this, unless you think this PR should not be merged, then we can apply further refactoring in separate PRs.

@mloskot mloskot merged commit 843ea37 into boostorg:develop Jun 3, 2022
@mloskot mloskot mentioned this pull request Jul 5, 2022
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mloskot mloskot mloskot approved these changes

Assignees
No one assigned
Labels
cat/refactoring Any nonfunctional changes ext/image_processing boost/gil/extension/image_processing ext/rasterization boost/gil/extension/rasterization
Projects
None yet
Milestone
Boost 1.80
Development

Successfully merging this pull request may close these issues.
3 participants
@simmplecoder @marco-langer @mloskot