chore!: deprecate any_color_converted_view #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
color_converted_view has the same implementation and can be used as a replacement, providing the same functionality.
2 tasks
mloskot
approved these changes
May 25, 2022
There was a problem hiding this comment.
Looks good!
This is initial part of deprecating the any_color_converted_view and as @marco-langer pointed in #660 (comment) there are more changes to follow.
mloskot
added
cat/deprecation
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
color_converted_viewhas the same implementation and can be used as a replacement, providing the same functionality.References
This builds on #660 by @marco-langer.
Since there needs to be a deprecation notice first before removing a feature, here it is.
Due to the fact that the switch to C++14 has been announced in #677, we can now officially use the
[[deprecated]]attribute which was standardized in C++14.Tasklist