-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Replace gil::detail::copy_n with std::copy_n #686
base: develop
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #686 +/- ##
===========================================
- Coverage 80.32% 80.27% -0.06%
===========================================
Files 117 117
Lines 5032 5019 -13
===========================================
- Hits 4042 4029 -13
Misses 990 990 |
detail::copy_n(src.x(), numToCopy, dst.x()); | ||
std::copy_n(src.x(), numToCopy, dst.x()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added line #L244 was not covered by tests
Hmm, this one is interesting. I'd have expected those to be fully covered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any test cases for core\algorithm\copy_pixels
. The other specializations of struct copier_n
are apparently triggered by some unrelated test cases from extension or image processing tests AFAIS.
Edit: this is not true, there are some legacy tests, which do not cover this case. However, the Jamfile in test\legacy
says these tests should not be refactored or extended. Thus, should we rather add new copy_pixels
tests in core\algorithm\copy_pixels.cpp
?
Description
This PR replaces Gil's
gil::detail::copy_n
withstd::copy_n
.Tasklist