Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Convolution in convolve_2d. #723

Merged
merged 1 commit into from
Feb 7, 2023
Merged

fix: Convolution in convolve_2d. #723

merged 1 commit into from
Feb 7, 2023

Conversation

cgringmuth
Copy link
Contributor

@cgringmuth cgringmuth commented Jan 31, 2023 •
edited by mloskot
Loading

Description

This PR fixes the issue explained in #722.

References

Tasklist

  • Add test case(s)
  • Ensure all CI builds pass
  • Review and approve

@cgringmuth cgringmuth force-pushed the fix/conv2d branch 2 times, most recently from c01f3a3 to d0f2f85 Compare January 31, 2023 16:12
@mloskot
Copy link
Member

mloskot commented Jan 31, 2023

The fix looks good to me, https://en.wikipedia.org/wiki/Sobel_operator also agrees

image

Since the previous values come from #392, I'd give @simmplecoder a chance to check the proposed fix.
If none arrives and our tests are green, I'm happy to merge it.

Thank you!

@mloskot mloskot added the ext/image_processing boost/gil/extension/image_processing label Jan 31, 2023
@cgringmuth cgringmuth mentioned this pull request Feb 1, 2023
Merged
4 tasks
mloskot
mloskot approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@mloskot mloskot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@mloskot mloskot merged commit 712b827 into boostorg:develop Feb 7, 2023
@mloskot mloskot added the cat/bug But reports and bug fixes label Feb 7, 2023
@mloskot mloskot added this to the Boost 1.81+ milestone Feb 7, 2023
@cgringmuth cgringmuth deleted the fix/conv2d branch February 7, 2023 14:17
@mloskot mloskot modified the milestones: Boost 1.82, Boost 1.83 Mar 31, 2023
@striezel striezel mentioned this pull request Jun 30, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mloskot mloskot mloskot approved these changes

Assignees
No one assigned
Labels
cat/bug But reports and bug fixes ext/image_processing boost/gil/extension/image_processing
Projects
None yet
Milestone
Boost 1.86
Development

Successfully merging this pull request may close these issues.
2 participants
@cgringmuth @mloskot