Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make locator.hpp self contained #729

Merged

Conversation

sdebionne
Copy link
Contributor

@sdebionne sdebionne commented Feb 20, 2023

Description

locator implementation uses make_step_iterator() but step_iterator.hpp is not included.

Tasklist

  • Ensure all CI builds pass
  • Review and approve

@mloskot mloskot added the cat/refactoring Any nonfunctional changes label Feb 20, 2023
@sdebionne
Copy link
Contributor Author

This fixes the following issue:

boost/gil/locator.hpp:258:32: error: 'make_step_iterator' was not declared in this scope, and no declarations were found by argument-dependent lookup at the point of instantiation [-fpermissive]
  258 |         : _p(make_step_iterator(loc.x(),(transpose ? loc.row_size() : loc.pixel_size())*x_step),
      |              ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
...
note: 'template<class I> typename boost::gil::dynamic_x_step_type<T>::type boost::gil::make_step_iterator(const I&, std::ptrdiff_t)' declared here, later in the translation unit

@mloskot mloskot merged commit ecea33a into boostorg:develop Feb 22, 2023
@sdebionne sdebionne deleted the make-locator-header-self-contained branch February 23, 2023 09:22
@sdebionne
Copy link
Contributor Author

@mloskot Do you think this little change could make it to master for 1.82?

@mloskot
Copy link
Member

mloskot commented Mar 21, 2023

@sdebionne I see no reason why not, unless the release managers object it.

@mloskot mloskot added this to the Boost 1.81+ milestone Mar 21, 2023
sdebionne added a commit to sdebionne/gil that referenced this pull request Mar 21, 2023
@striezel striezel mentioned this pull request Jun 30, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat/refactoring Any nonfunctional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants