Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add release notes for Boost 1.86 #749

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

striezel
Copy link
Contributor

Description

Includes release notes for the changes seen in the table in #748, i.e. the changes for a potential Boost 1.86 release of GIL.

References

See #748.

Tasklist

  • Review and approve

@striezel striezel mentioned this pull request Jun 30, 2024
6 tasks
@striezel
Copy link
Contributor Author

striezel commented Jul 3, 2024

The one job that failed here was "posix (clang, 14,17, macos-11)". That is a bit strange, because a documentation update should not cause CI failure. Here's what the summary says:

This request was automatically failed because there were no enabled runners online to process the request for more than 1 days.

That should not happen - unless no such runners are available at all. Turns out they are no longer available: https://github.blog/changelog/2024-05-20-actions-upcoming-changes-to-github-hosted-macos-runners/

In January 2024, GitHub announced the deprecation of macOS 11 and the removal of the runner image by June 2024. The macOS 11 runner image will be removed on 6/28/2024. We recommend updating workflows to use macos-14, macos-13, macos-12, or macos-latest.

We are now past the date when the macOS 11 runner image was removed, and that is why that CI job failed.

@sdebionne
Copy link
Contributor

Thanks for looking into this and the doc improvements. I don't know much about the CI setup on this project but I think that @mloskot who also contributed to boostorg/boost-ci used it to set it up. So maybe it is just a question of merging with the latest boost-ci (the GH actions part)?

Copy link
Member

@mloskot mloskot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @striezel for this update, your efforts are priceless!

@sdebionne Yes, I did some contributions to boost-ci project, but AFAIR I stopped using it for GIL a while ago, some time around dropping use of Travis CI. Then, I have been following Boost.MP11's https://github.com/boostorg/mp11/blob/develop/.github/workflows/ci.yml to catch up with changes and deprecations in GitHub Actions.

Long story short, I think we can ignore this change and approve this PR.

@striezel You are right, I think we should not run the whole CI for changes like this. It looks like we could improve it with exclusions based on paths/files filter, https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-excluding-paths

@mloskot mloskot merged commit 6e49d52 into boostorg:develop Jul 4, 2024
17 of 18 checks passed
@striezel striezel deleted the release-notes-for-1.86 branch July 4, 2024 21:20
@striezel striezel mentioned this pull request Jul 4, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants