Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure we don't activate float128 use when explicitly disabled #1207

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

mborland
Copy link
Member

@kursatyurt can you please give this patch a go and see if it solves your issue? If not can you please add a minimal reproducer and toolchain used to your issue. Thanks

@kursatyurt
Copy link

@mborland Thanks, this solves the issue. I will write a reproducer if I can find time.
I am using nvcc 12.2. It was in a more complex project with Kokkos; hopefully, I can write a minimal example.

@mborland
Copy link
Member Author

@mborland Thanks, this solves the issue. I will write a reproducer if I can find time. I am using nvcc 12.2. It was in a more complex project with Kokkos; hopefully, I can write a minimal example.

Sounds good. FYI since the last release much of the library now supports running on device with NVCC and NVRTC.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.78%. Comparing base (260f760) to head (a6afa23).
Report is 6 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1207   +/-   ##
========================================
  Coverage    93.78%   93.78%           
========================================
  Files          657      657           
  Lines        53903    53903           
========================================
  Hits         50555    50555           
  Misses        3348     3348           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 260f760...a6afa23. Read the comment docs.

@jzmaddock
Copy link
Collaborator

Thanks guys, looks good to me!

@mborland mborland merged commit bb7539e into develop Oct 10, 2024
79 checks passed
@NAThompson NAThompson deleted the FLT_128_Config branch October 10, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants