Fix icx warning: explicit comparison with infinity in fast floating point mode with intel compiler

[pps83]

fixes #1217

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.78%. Comparing base (097b73c) to head (1532d1a).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@            Coverage Diff            @@
##           develop    #1218    +/-   ##
=========================================
  Coverage    93.77%   93.78%            
=========================================
  Files          657      654     -3     
  Lines        55285    55090   -195     
=========================================
- Hits         51846    51664   -182     
+ Misses        3439     3426    -13     

see 4 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 097b73c...1532d1a. Read the comment docs.

[mborland]

This looks fine to me. I'm not sure when -Wtautological-constant-compare was added but as long as CI is green it should be OK. I don't think we'd gain anything from restricting this to __INTEL_LLVM_COMPILER in case base clang picks up the behavior.

[pps83]

__INTEL_LLVM_COMPILER

Yes, __INTEL_LLVM_COMPILER can be used to check for new intel compiler only. Let me know if I should replace the checks

[pps83]

This looks fine to me. I'm not sure when -Wtautological-constant-compare was added but as long as CI is green it should be OK. I don't think we'd gain anything from restricting this to __INTEL_LLVM_COMPILER in case base clang picks up the behavior.

I updated it with __clang__major__ >= 6 check based on this code: https://github.com/zouyonghao/DistFuzz/blob/1022471d1883e38ba4d26f9da29a9aa73280b0ff/strace/src/gcc_compat.h#L153

[mborland]

This looks fine to me. I'm not sure when -Wtautological-constant-compare was added but as long as CI is green it should be OK. I don't think we'd gain anything from restricting this to __INTEL_LLVM_COMPILER in case base clang picks up the behavior.

I updated it with __clang__major__ >= 6 check based on this code: https://github.com/zouyonghao/DistFuzz/blob/1022471d1883e38ba4d26f9da29a9aa73280b0ff/strace/src/gcc_compat.h#L153

I approved the CI run and will merge once we get a result. Since we require C++14 I don't think anything below Clang 6 works anyway but it doesn't hurt to have the check.