Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add protobuf example #81

Closed
mzimbres opened this issue Mar 10, 2023 · 3 comments · Fixed by #82
Closed

Add protobuf example #81

mzimbres opened this issue Mar 10, 2023 · 3 comments · Fixed by #82

Comments

@mzimbres
Copy link
Collaborator

Reference: https://protobuf.dev/

@vinniefalco
Copy link
Member

vinniefalco commented Mar 10, 2023

Protocol Buffers are not that great... can this be a separate library? What is the motivating use-case for this? It sort of doesn't make sense that a low-level RESP3 client has to know about an ever-increasing amount of non-Redis things. Perhaps we could instead have a customization point allowing users to integrate whatever third party libraries they want?

For example Cap'n Proto:
https://capnproto.org/

Or Boost.Serialization:
https://www.boost.org/doc/libs/1_81_0/libs/serialization/doc/index.html

There is a significant part of the C++ community that hates protocol buffers:
https://reasonablypolymorphic.com/blog/protos-are-wrong/

@mzimbres
Copy link
Collaborator Author

What about having it only as an example?

@vinniefalco
Copy link
Member

Examples are great, and preferred.

@mzimbres mzimbres changed the title Add support for protobuf Add protobuf example Mar 10, 2023
@mzimbres mzimbres linked a pull request Mar 10, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants