fix debug_enabled on steps and error handling #117
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
debug_enabled
rule:step
metadata value. It must be the step's index since the id is not always defined.in analyze_org, log errors instead of cancelling the entire analysis of the org (see #102). Because of the wrong step reported in the
debug_enabled
rule, an org that had debugging enabled on a single workflow step could not be analyzed at all.Make it so
FindingMeta
parsing error are logged instead. Currently, if a finding with metadata that cannot be parse would crash the org's analysis with the following error:Now it logs the error and the metadata it tried to parse: