fix: verbose log level #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@becojo yeah I see what is going on here. InitConfig is called before each command and has the flags values set to what was passed |
becojo
force-pushed
the
fix-verbose-logging
branch
from
7f55223 to
504f2b0
Compare
becojo
force-pushed
the
fix-verbose-logging
branch
from
504f2b0 to
3705dc0
Compare
SUSTAPLE117
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmd.Verbose isn't set yet in the Execute function it seems and verbose logging can't be enabled. I moved the call to set the log level after the config file parsing in initConfig and it worked 🤷
I'm not sure if there is somewhere else the logger should be initialized instead.Moved log initialization into the PersistentPreRun hook.