[BOOST-4786] feat(sdk,EventAction): add deriveActionClaimantFromTransaction method #194
Conversation
🦋 Changeset detectedLatest commit: 4b43ebc The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| params: ValidateActionStepParams, | ||
| ) { | ||
| if (!('logs' in params)) { | ||
| throw new ValidationLogsMissingError(); |
There was a problem hiding this comment.
We can remove this error since this was the only place it was used
| knownSignatures?: Record<Hex, AbiEvent | AbiFunction>; | ||
| abiItem?: AbiEvent | AbiFunction; |
There was a problem hiding this comment.
Awesome ty for adding function support
There was a problem hiding this comment.
ty for doing literally all the hard work and letting me ctrl+c your work
| for (let log of decodedLogs) { | ||
| if (!isAddressEqual(log.address, claimant.targetContract)) continue; | ||
| let addressCandidate = this.validateClaimantAgainstArgs(claimant, log); | ||
| if (addressCandidate) address = addressCandidate; | ||
| } | ||
| return address; |
There was a problem hiding this comment.
Thinking out loud here on an edge case here: would deriving claimant from event only work for txs with a single event? Cause if there are multiple event logs that match, it would basically just return the last match
There was a problem hiding this comment.
but I guess we can make sure that when defining an action claimant that the values must be strict!
There was a problem hiding this comment.
Thinking out loud here on an edge case here: would deriving claimant from event only work for txs with a single event? Cause if there are multiple event logs that match, it would basically just return the last match
yeah wasn't really sure how to handle that, @Quazia is this approach decent?
…, refactor ValidateActionStepParams slightly chore: address feedback
sammccord
force-pushed
the
sam/boost-4786-feat-derive-claimant
branch
from
15d4a60
to
4b43ebc
Compare
🚨 Please review the guidelines for contributing to this repository.
Description
EventActions's claimant configuration given a tx hash or logsValidateActionStepParamsto use event/function agnostic naming/typing and make accessing abi items off the params more consistent for action step validation as wellfix #139
💔 Thank you!