-
-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow exclusion of specific directories from being watched #312
Conversation
We already are traversing the tree when we add the watchers. The way the fsevent stuff works you need to add a watcher to each directory---it needs a separate one for each directory. Like if you have a directory with subdirectories you need to add a watcher to each of the subdirectories and to each of their subdirectories etc. This is already in place, so we could do it there, couldn't we? |
Also boot relies on the file watchers to function correctly if you want those files to be in the fileset. So for something like node_modules i think you'd want a task that can just sync them to the target without ingesting them into the fileset. This will be much easier if we eliminated automatic target syncing and made it a separate task, as we discussed on slack. |
The files in excluded dirs were still present in the fileset. I was also somewhat surprised tbh.
Could I also add them to the classpath in a "static" way? The traversing is there but essentially we would need another full traversal to create a tree of directories and filecounts right? Then we would still need to come up with some potentially arbitrary measures to decide whether to cut of a subtree from watching. |
You might also want them on the classpath — are there means to put stuff on the classpath without it going through the fileset? Maybe the solution is a task that packages Then we can also just forget about all of this stuff. |
useful for node_modules and similar stuff