Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow exclusion of specific directories from being watched #312

Closed
wants to merge 2 commits into from

Conversation

martinklepsch
Copy link
Member

@martinklepsch martinklepsch commented Oct 22, 2015

useful for node_modules and similar stuff

@martinklepsch
Copy link
Member Author

@micha re your comment on #248

That would be less predictable and I assume the implementation would be more complex.

  • We would need to traverse the tree and count files
  • Then decide where we cut it off. Don't see a good decision criteria for this yet.

@micha
Copy link
Contributor

micha commented Oct 22, 2015

We already are traversing the tree when we add the watchers. The way the fsevent stuff works you need to add a watcher to each directory---it needs a separate one for each directory. Like if you have a directory with subdirectories you need to add a watcher to each of the subdirectories and to each of their subdirectories etc. This is already in place, so we could do it there, couldn't we?

@micha
Copy link
Contributor

micha commented Oct 22, 2015

Also boot relies on the file watchers to function correctly if you want those files to be in the fileset. So for something like node_modules i think you'd want a task that can just sync them to the target without ingesting them into the fileset. This will be much easier if we eliminated automatic target syncing and made it a separate task, as we discussed on slack.

@martinklepsch
Copy link
Member Author

Also boot relies on the file watchers to function correctly if you want those files to be in the fileset.

The files in excluded dirs were still present in the fileset. I was also somewhat surprised tbh.

So for something like node_modules i think you'd want a task that can just sync them to the target without ingesting them into the fileset.

Could I also add them to the classpath in a "static" way?


The traversing is there but essentially we would need another full traversal to create a tree of directories and filecounts right? Then we would still need to come up with some potentially arbitrary measures to decide whether to cut of a subtree from watching.

@martinklepsch
Copy link
Member Author

So for something like node_modules i think you'd want a task that can just sync them to the target without ingesting them into the fileset.

You might also want them on the classpath — are there means to put stuff on the classpath without it going through the fileset? Maybe the solution is a task that packages node_modules as a jar?

Then we can also just forget about all of this stuff.

@micha micha removed this from the 2.6.0 milestone Jul 29, 2016
@micha micha added this to the 2.7.0 milestone Aug 28, 2016
@micha micha self-assigned this Aug 28, 2016
@micha micha closed this in 076870c Aug 28, 2016
@micha micha removed the ready label Aug 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants