Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --mode option to built in target task #537

Merged
merged 2 commits into from
Dec 15, 2016

Conversation

ekroon
Copy link
Contributor

@ekroon ekroon commented Dec 3, 2016

For situations where the default 'rw-------' file modes are not enough,
a (posix) mode string can be given to target. All files will get the
mode written.

When an invalid mode is given, a warning is printed and standard
permissions will be used.

@alandipert
Copy link
Contributor

Has anyone tried this on Windows?

@ekroon
Copy link
Contributor Author

ekroon commented Dec 9, 2016

Good point, I implemented it this way, because tmp files already are created with PosixFilePermissions. Maybe I missed a Windows check somewhere as there is a good chance this doesn't work on Windows indeed. I did not check, so I will check it and adapt if necessary.

@alandipert
Copy link
Contributor

@ekroon cool, thank you. I haven't checked myself, so it may very well work. I just wanted to make sure someone has tried it.

@ekroon
Copy link
Contributor Author

ekroon commented Dec 9, 2016

In https://github.com/asciidoctor/atom-language-asciidoc they use www.appveyor.com for Windows testing. Would that be an option for boot?

@alandipert
Copy link
Contributor

Can you please add arities to link! and copy! that don't take mode, but call the arity that does with a value of nil for mode?

Then the arity change is backward compatible. Thanks 🤘

@alandipert
Copy link
Contributor

alandipert commented Dec 13, 2016

It looks like the earlier PosixFilePermissionsrelated code did break Boot on windows, so presumably this would too: #541

@alandipert
Copy link
Contributor

@ekroon I don't have experience with appveyor but am certainly open to it.

For situations where the default 'rw-------' file modes are not enough,
a (posix) mode string can be given to target. All files will get the 
mode written.

When an invalid mode is given, a warning is printed and standard 
permissions will be used.
@ekroon
Copy link
Contributor Author

ekroon commented Dec 14, 2016

@alandipert took the liberty to also fix #541 on this branch as it is closely related.

@alandipert alandipert merged commit b89738e into boot-clj:master Dec 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants