Sift now outputs meaningful things on debug #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arichiardi
force-pushed
the
sift-on-dbug
branch
from
b10fba7
to
a6a1431
Compare
boot/core/src/boot/task/built_in.clj
Outdated
| @@ -575,7 +575,7 @@ | |||
| action (partial helpers/sift-action v?) | |||
| process (reduce-kv #(comp (action %2 %3) %1) identity *opts*)] | |||
| (core/with-pre-wrap [fs] | |||
| (util/info "Sifting output files...\n") | |||
| (util/dbug* "Sifting with opts: %s\n" (util/pp-str (assoc *opts* :invert v?))) | |||
There was a problem hiding this comment.
I think personally I would rather still have it print the output by default rather than only on debug. It's a common behavior for most built-in tasks to print something indicating which task was run, and it helps as a base level sanity check that the tasks you think are running are actually happening.
Big 👍 to making the output more meaningful!
arichiardi
force-pushed
the
sift-on-dbug
branch
from
a6a1431
to
dd49dfb
Compare
|
@RadicalZephyr Ok I have just added the |
|
ummm, @arichiardi I think you pushed the wrong branch to this PR. It looks like it has your changes for the pom parent tag PR... |
|
Oh, fixing...Thanks!
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
arichiardi
force-pushed
the
sift-on-dbug
branch
from
dd49dfb
to
51ee2bb
Compare
arichiardi
changed the title
|
Looks good, thanks! When you have a moment, could you please add to CHANGES.md? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.