Write manifest file first in update-jar! #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RadicalZephyr
force-pushed
the
710-jar-compatability
branch
from
9120b1b
to
7226149
Compare
It appears to be a de facto standard for the meta-inf directory and the manifest.mf file to be the first and second entries in the jar file.
RadicalZephyr
force-pushed
the
710-jar-compatability
branch
from
7226149
to
3ed463c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears to be a de facto standard for the meta-inf directory and the manifest.mf file to be the first and second entries in the jar file.
There is no mention of ordering in the jar specification, but it appears that most tools create Jar files with the manifest file as the first entry by using this
JarOutputStreamconstructor. In addition the complementary jar reading code inJarInputStreamexplicitly states that it assumes the first few entries contain the manifest file.At least one other tool is known to rely on this detail of jar file ordering.
While it may not be necessary according to the spec, it seems reasonable to follow this fairly standard ecosystem behavior.
This fixes #710.