Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Attribute for handling OOS products #54

Merged
merged 3 commits into from
Oct 13, 2023

Conversation

DogByteMarketing
Copy link
Contributor

Added: Out of Stock attribute to handle showing (true) or hiding (false) OOS products.

Added: Out of Stock attribute to handle showing (true) or hiding (false) OOS products.
@crftwrk crftwrk added the documentation Improvements or additions to documentation label Oct 13, 2023
Copy link
Member

@crftwrk crftwrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

*
* Optional:
* featured="true" Shortcode it will pull featured products.
* featured="true" will pull featured products.
* oos="false" will hide out of stock products.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

oos="" seems a bit confusing for me, think out-of-stock="" is more clear. Want to change that?

Edit: You are right, oos is good.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were trying to keep it short like the other attributes, but we understand how it can be confusing. If you'd like, we can change it to "outofstock" to keep it inline with WooCommerce's naming scheme.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, as edited in my request, oos is good and merged. Do you have some more ideas right now? Asking because we should release now or wait a bit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None at the moment.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, quickly changed oos into outofstock. After some thought, I think it's better.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, thanks.

@crftwrk crftwrk merged commit 1645a79 into bootscore:main Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants