-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Attribute for handling OOS products #54
Conversation
Added: Out of Stock attribute to handle showing (true) or hiding (false) OOS products.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 👍
* | ||
* Optional: | ||
* featured="true" Shortcode it will pull featured products. | ||
* featured="true" will pull featured products. | ||
* oos="false" will hide out of stock products. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
oos=""
seems a bit confusing for me, think out-of-stock=""
is more clear. Want to change that?
Edit: You are right, oos is good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We were trying to keep it short like the other attributes, but we understand how it can be confusing. If you'd like, we can change it to "outofstock" to keep it inline with WooCommerce's naming scheme.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, as edited in my request, oos
is good and merged. Do you have some more ideas right now? Asking because we should release now or wait a bit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None at the moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, quickly changed oos
into outofstock
. After some thought, I think it's better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, thanks.
Added: Out of Stock attribute to handle showing (true) or hiding (false) OOS products.