Improve product template shortcode options #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated: Shortcode to function more like how WooCommerce does Removed: extract function as it goes against WordPress Developer Standards Bugfix: Default order was set to "order" instead of DESC. Bugfix: Set limit of 12 for default as currently set to no limit Security: Contributors and up have access to shortcodes, sanitized attributes to prevent malicious behavior.
Updated: Spacing of code as it somehow got out of line.
DogByteMarketing
changed the title
crftwrk
changed the title
crftwrk
reviewed
Oct 27, 2023
|
FYI, replaced |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If these changes are approved, we can go through the other templates and sync the changes where appropriate, though it may be a couple weeks before we can get to it.
Added: ids attribute to pull in specific products.
Updated: Shortcode to function more like how WooCommerce does
Removed: extract function as it goes against WordPress Developer Standards
Bugfix: Default order was set to "order" instead of DESC.
Bugfix: Set limit of 12 for default as currently set to no limit
Security: Contributors and up have access to shortcodes, sanitized attributes to prevent malicious behavior.