Move errors inside input-group and form-group.
#434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added method for error and help and optionally prepend and append.
Here's an example of a CHANGELOG.md entry (place it immediately under the * [#434](https://github.com/bootstrap-ruby/bootstrap_form/pull/434): Move errors inside `input-group` and `form-group`. - [@lcreid](https://github.com/lcreid).Generated by 🚫 Danger |
mattbrictson
approved these changes
Feb 23, 2018
There was a problem hiding this comment.
Nice work! ✨
I'll merge #433 first, then check back here to make sure there aren't any conflicts.
lcreid
added a commit
to lcreid/rails-bootstrap-forms
that referenced
this pull request
Jun 4, 2018
* Test case for bootstrap-ruby#417. * Undoing mess created on wrong branch. * Remove test that accidentally leaked in from another branch. * Working but needs cleanup bootstrap-ruby#417. * Partially cleaned up. Added method for error and help and optionally prepend and append. * Remove unneeded method and parameters. * Test selects error. * Test selects error. * time_zone_select works for new error placement. * Add tests for date, time, datetime selects. * Add tests for date, time, datetime selects. * date, time, datetime tests pass with old implementation. * Date, time, and datetime for new implementation. * Tests for file and collection selects. * File and collection selects with new implementation. * Keep tests but revert lib to try another approach. * form_group tests passing. * Clean up and add back commented test. * checkbox and radio button tests still have old behaviour. * Clean up and block append and prepend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like Bootstrap 4 specifies that errors should be wrapped inside the input or form group (see twbs/bootstrap#25020 and https://getbootstrap.com/docs/4.0/components/forms/#validation). This PR moves the error (and help) text inside the input-group and form-group.
(Based on the examples in the Bootstrap docs, the error and help text doesn't have to be inside an input or form group, but they do have to be within the same container as the input or select, and label (if any) of the control.)
This PR is a second attempt to address this issue. It's mutually exclusive with PR #422, the first attempt.
The changes introduced by this PR can be summarized as:
form_groupform_groupis called. This is kind of ugly, but if issue:appendand:prependnot applied to collection selects. #428 is resolved by deciding that :append and :prepend should be available to all or almost all helpers, the method for stripping options will be less of an issuein PR #422, there was one test in bootstrap_form_group_test.rb that was commented out. The approach in this PR does not comment out that test. With this approach, users' code should work without change in all cases.
Fixes #417.
Fixes #395. This PR should cover the last issues around the changed format for check boxes and radio buttons.