Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update input group addon changes from bootstrap beta 3 #1505

Merged
merged 1 commit into from Jan 3, 2018
Merged

update input group addon changes from bootstrap beta 3 #1505

merged 1 commit into from Jan 3, 2018

Conversation

toadkicker
Copy link
Contributor

This addresses changes introduced in twbs/bootstrap#25020

  • drops the .input-group-addon class and replaces it with .input-group-prepend and .input-group-append depending on the value of the slot
  • deprecates the .input-group-btn class and uses the classes above
  • defaults component to input-group-append if no slot value provided
  • updates specs

@codecov
Copy link

codecov bot commented Jan 3, 2018

Codecov Report

Merging #1505 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1505   +/-   ##
=======================================
  Coverage   53.26%   53.26%           
=======================================
  Files         134      134           
  Lines        2191     2191           
  Branches      698      698           
=======================================
  Hits         1167     1167           
  Misses        728      728           
  Partials      296      296

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3fe0f4...3bec55e. Read the comment docs.

@toadkicker
Copy link
Contributor Author

I don't know if this should just become two separate components instead of using a slot/prop definition, e.g <input-group-prepend> vs current method. If that is preferred over this solution I'm happy to provide it.

@pi0
Copy link
Member

pi0 commented Jan 3, 2018

Thanks. I think this change was necessary to provide this update with minimum code change impact. But adding support for <input-group-append|prepend> would be much better for long-term. So PR welcomes for those components.

@pi0 pi0 changed the base branch from dev to feat/beta-3 January 3, 2018 08:31
@pi0 pi0 merged commit 153507a into bootstrap-vue:feat/beta-3 Jan 3, 2018
@tmorehouse
Copy link
Member

Yeah, this needs to be two new components (replacing the single add-on component and button addon).

See the issue that we are using to track the changes needed for bootstrap v4.beta.3 #1408

@toadkicker
Copy link
Contributor Author

I got a chance to check this out more today. The new style needs to have a child element of div.input-group-text in order for the styles to get picked up. This change does not insert the additional div around the text. I'll figure out how to do that next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants