Remove early initialization (Fix #563) #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
added a commit
to Avasam/AutoSplit
that referenced
this pull request
Sep 15, 2022
|
I don't think skipping an import error is ideal, but it definitely fixes this important error. Thanks for the contribution! |
Agreed the macos Quartz import fix is a bandaid fix. Imo setup.py should maybe not import from keyboard? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't initialize the keyboard by simply importing the module. This is often too soon. And runs when installing (because
setup.pyimportskeyboard).The keyboards are initialized later anyway through
start_if_necessaryFixes #563