Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

borg2 - Support other OpenSSL versions on OpenBSD (#8553) #8557

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

bket
Copy link
Contributor

@bket bket commented Nov 23, 2024

setup.py hardcoded crypto library paths for OpenBSD, causing build issue when OpenBSD drops specific OpenSSL version. Solution is to make paths configurable.

Addresses #8553.

@bket bket force-pushed the openbsd_openssl_version branch from 6e5a94c to 127d80b Compare November 23, 2024 07:08
Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.51%. Comparing base (33834c4) to head (cf6a324).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8557      +/-   ##
==========================================
- Coverage   81.79%   81.51%   -0.28%     
==========================================
  Files          74       74              
  Lines       13292    13292              
  Branches     1957     1957              
==========================================
- Hits        10872    10835      -37     
- Misses       1756     1785      +29     
- Partials      664      672       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@bket bket changed the title borg2 - Support other OpenSSL versions on OpenBSD borg2 - Support other OpenSSL versions on OpenBSD (#8553) Nov 23, 2024
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@ThomasWaldmann
Copy link
Member

macos CI failure: looks unrelated, somebody fscked with pkg-config in brew.

@bket bket force-pushed the openbsd_openssl_version branch from 127d80b to 3f2df5a Compare November 23, 2024 20:14
`setup.py` hardcoded crypto library paths for OpenBSD, causing build
issue when OpenBSD drops specific OpenSSL version. Solution is to make
paths configurable.

Addresses borgbackup#8553.
@bket bket force-pushed the openbsd_openssl_version branch from 3f2df5a to cf6a324 Compare November 23, 2024 22:02
@ThomasWaldmann ThomasWaldmann merged commit b8fe10d into borgbackup:master Nov 24, 2024
14 of 16 checks passed
@ThomasWaldmann
Copy link
Member

Thanks!

@bket bket deleted the openbsd_openssl_version branch November 25, 2024 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants