Vagrant updates2 (1.4) #8610
Merged
Vagrant updates2 (1.4) #8610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should address borgbackup#8506. Unfortunately I'm unable to test. borgbackup#8506 is likely caused by the Vagrant box having a mirror in its `etc/installurl`, which does not offer 7.4 packages. There are other mirrors out there who do, e.g., https://ftp.eu.openbsd.org/pub/OpenBSD/. Proposed 'fix' is to replace the mirror in `/etc/installurl`.
We do not want that urllib spoils test output with LibreSSL related warnings on OpenBSD. `NotOpenSSLWarning: urllib3 v2 only supports OpenSSL 1.1.1+, currently the 'ssl' module is compiled with 'LibreSSL 3.8.2'`.
Installing 3.9/10/12 involves downloading and compiling these, which takes a lot of time and has some potential breaking the boxes by installing misc. openssl versions. We test misc. python versions on github actions CI all the time, so we only need the one here which we want to use for the binary builds.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 1.4-maint #8610 +/- ##
=============================================
- Coverage 82.23% 82.11% -0.12%
=============================================
Files 38 38
Lines 11116 11117 +1
Branches 1725 1725
=============================================
- Hits 9141 9129 -12
- Misses 1408 1418 +10
- Partials 567 570 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.