Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DecisionTree Improvements #1002

Merged
merged 4 commits into from
Jan 3, 2022
Merged

DecisionTree Improvements #1002

merged 4 commits into from
Jan 3, 2022

Conversation

varunagrawal
Copy link
Collaborator

@varunagrawal varunagrawal commented Jan 3, 2022 •
edited
Loading

1. Moved DefaultFormatter to base class in ADT.
2. Replace Super with Base in ADT.
3. Use using instead of typedef.
4. Improved docs.

@dellaert this should address all my review comments in #1000.

@varunagrawal varunagrawal requested a review from dellaert January 3, 2022 05:09
@varunagrawal varunagrawal self-assigned this Jan 3, 2022
dellaert
dellaert approved these changes Jan 3, 2022
View reviewed changes
Copy link
Member

@dellaert dellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks ! For future reference:

  • node type -> value type (only relevant to leaf nodes)
  • node label -> label type (only relevant to choice nodes)

But I will change that.

@dellaert dellaert merged commit 8a28ac2 into feature/decison_tree Jan 3, 2022
@dellaert dellaert deleted the feature/decision_tree_2 branch January 3, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dellaert dellaert dellaert approved these changes

Assignees

@varunagrawal varunagrawal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varunagrawal @dellaert