Fix DotWriter wrapping #1089
Merged
Fix DotWriter wrapping #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No idea what is going on with CI here... |
varunagrawal
approved these changes
Feb 6, 2022
|
I'm merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@varunagrawal , this commit removed the line
which was needed to access and update the fields in
gtsam.DotWriter, which I need in gtbook. Admittedly, there was no test in gtsam that showed this line is crucial. This PR fixes that by adding a test and adding the line back in.PS, this was a pain to debug as the wrapper cmake scripts do not copy over files in preamble and specializations after they have been touched. I had to manually update the copy in the build folder. Maybe something to fix in wrap after IROS deadline.