Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove user flag for pip install #1195

Merged
merged 2 commits into from
May 11, 2022
Merged

Remove user flag for pip install #1195

merged 2 commits into from
May 11, 2022

Conversation

varunagrawal
Copy link
Collaborator

This PR fixes an issue where the python package is not installed correctly to the conda environment under consideration.

I created a conda env called py38-test and verified that removing the flag ensures the install location is under that environment.

I also added printing of the python interpreter's patch version since it is helpful if we have two versions such as 3.8.11 and 3.8.13.

@varunagrawal varunagrawal added python Related to python wrapper quick-review Quick and easy PR to review labels May 11, 2022
@varunagrawal varunagrawal requested a review from dellaert May 11, 2022 16:08
@varunagrawal varunagrawal self-assigned this May 11, 2022
Copy link
Member

@dellaert dellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !!!

@dellaert dellaert merged commit 9c88249 into develop May 11, 2022
@dellaert dellaert deleted the fix/python-install branch May 11, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Related to python wrapper quick-review Quick and easy PR to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants