Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jose's updates #1237

Merged
merged 3 commits into from
Aug 21, 2022
Merged

Jose's updates #1237

merged 3 commits into from
Aug 21, 2022

Conversation

varunagrawal
Copy link
Collaborator

Adding the updates @jlblancoc made as per #1174 (comment)

@varunagrawal varunagrawal requested a review from jlblancoc July 7, 2022 15:04
@varunagrawal varunagrawal self-assigned this Jul 7, 2022
@varunagrawal varunagrawal reopened this Jul 7, 2022
@varunagrawal varunagrawal requested a review from ProfFan July 11, 2022 09:36
Copy link
Collaborator

@ProfFan ProfFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think march=native on is a good default, errors related to this are probably deeper issues like different compilation flags that is misunderstood to be a march issue.

I think the Eigen change is good :)

@varunagrawal
Copy link
Collaborator Author

I think march=native on is a good default, errors related to this are probably deeper issues like different compilation flags that is misunderstood to be a march issue.

I am no expert on architecture specific code generation, but @jlblancoc seemed to think setting march=native off was a good idea.

From a more practical standpoint, I have noticed issues when compiling downstream repos (e.g. GTDynamics, GPMP2 etc) when the march=native flag is on, and these are incredibly hard to debug. For this reason, I still think the default should be OFF and those who want the extra boost from architecture specific machine code can turn it on (aka generality over performance).

@varunagrawal varunagrawal merged commit fb8d6ab into develop Aug 21, 2022
@varunagrawal varunagrawal deleted the jose-fixes branch August 21, 2022 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants