Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.2: Fix an invalid include, restore C++11 compatibility #1545

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jun 15, 2023

C++11 compatibility in 4.2a9 is currently broken due to this single minor bug.

Cropped up in conan-io/conan-center-index#17933

Fixes incorrect header being included, which also broke C++11 compatibility.
@varunagrawal varunagrawal requested a review from dellaert June 15, 2023 17:46
Copy link
Collaborator

@varunagrawal varunagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh interesting that this was missed. Thanks for catching it @valgur. LGTM

@dellaert we might need to update the 4.2 release file.

@valgur valgur changed the title 4.2: Fix an invalid include, restore C+11 compatibility 4.2: Fix an invalid include, restore C++11 compatibility Jun 15, 2023
@dellaert
Copy link
Member

Thanks, will merge !

@dellaert dellaert merged commit eca51af into borglab:release/4.2 Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants