Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved documentation, wrapper, and tests #1574

Merged
merged 15 commits into from
Jul 16, 2023

Conversation

dellaert
Copy link
Member

After ICRA I made a number improvements to the wrapper in 4.2, for discrete and symbolic Bayes trees and cluster tress, mostly to be able to share an idea with a collaborator. I want to add this to develop as well but the notebook I shared uses gtbook which is still 4.2. I'll try to add these changes to develop as well by cherry-picking.

@dellaert dellaert requested a review from varunagrawal July 12, 2023 08:44
Copy link
Collaborator

@varunagrawal varunagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great except for a couple of comments.

You may want to look into the CI?

gtsam/discrete/tests/testDecisionTree.cpp Outdated Show resolved Hide resolved
gtsam/inference/BayesTreeCliqueBase.h Outdated Show resolved Hide resolved
gtsam/inference/inference.i Show resolved Hide resolved
@dellaert dellaert merged commit 13c7daf into release/4.2 Jul 16, 2023
@dellaert dellaert deleted the feature/improved_wrapper branch July 16, 2023 19:43
@dellaert dellaert restored the feature/improved_wrapper branch July 16, 2023 19:43
@dellaert dellaert deleted the feature/improved_wrapper branch August 6, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants