Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++11 and "-march=native" flags done via "modern" CMake target-based properties #27

Closed
wants to merge 22 commits into from
Closed

C++11 and "-march=native" flags done via "modern" CMake target-based properties #27

wants to merge 22 commits into from

Commits on Jun 12, 2019

  1. Global env variables

    @dellaert @jlblancoc
    dellaert authored and jlblancoc committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    646469e View commit details
    Browse the repository at this point in the history

  2. Always run in debug mode

    @dellaert @jlblancoc
    dellaert authored and jlblancoc committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    0edf123 View commit details
    Browse the repository at this point in the history

  3. Removed redundant flags. 

    Add commented out code to turn off clang on Linux.
    @dellaert @jlblancoc
    dellaert authored and jlblancoc committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    bcaa61f View commit details
    Browse the repository at this point in the history

  4. Test both Debug and Release

    @dellaert @jlblancoc
    dellaert authored and jlblancoc committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    6d94dff View commit details
    Browse the repository at this point in the history

  5. Add Debug/Release in compile stage as well

    @dellaert @jlblancoc
    dellaert authored and jlblancoc committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    42efc13 View commit details
    Browse the repository at this point in the history

  6. provide

    @jlblancoc
    jlblancoc committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    dbeeb98 View commit details
    Browse the repository at this point in the history

  7. add command make check_valgrind

    @jlblancoc
    jlblancoc committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    e624d4a View commit details
    Browse the repository at this point in the history

  8. targets renamed: xxx.valgrind

    @jlblancoc
    jlblancoc committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    8977193 View commit details
    Browse the repository at this point in the history

  9. re-indent: script had an inconsistent mix of tabs and spaces

    @jlblancoc
    jlblancoc committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    40250e3 View commit details
    Browse the repository at this point in the history

  10. added inline keywords to new functions introduced in PR #32

    @varunagrawal @jlblancoc
    varunagrawal authored and jlblancoc committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    32e15ea View commit details
    Browse the repository at this point in the history

  11. Fixed exception type for TBB path

    @dellaert @jlblancoc
    dellaert authored and jlblancoc committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    83e4021 View commit details
    Browse the repository at this point in the history

  12. Use command line argument for script so that cache names are not poll… 

    …uted by environment variables. This should allow ccache to use caches from build stage for testing stage.
    @dellaert @jlblancoc
    dellaert authored and jlblancoc committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    b53d3d9 View commit details
    Browse the repository at this point in the history

  13. exclude clang on linux

    @dellaert @jlblancoc
    dellaert authored and jlblancoc committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    4bd45b8 View commit details
    Browse the repository at this point in the history

  14. Fix syntax error, add comment mentioning issue #57

    @dellaert @jlblancoc
    dellaert authored and jlblancoc committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    e38ac41 View commit details
    Browse the repository at this point in the history

  15. Reduced time to run very slow testScenario by reducing sample count f… 

    …or estimating covariance.
    @dellaert @jlblancoc
    dellaert authored and jlblancoc committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    108ee1d View commit details
    Browse the repository at this point in the history

  16. Reduced time for ImuFactor tests

    @dellaert @jlblancoc
    dellaert authored and jlblancoc committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    6c85332 View commit details
    Browse the repository at this point in the history

  17. Fixed warning

    @dellaert @jlblancoc
    dellaert authored and jlblancoc committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    fa81e17 View commit details
    Browse the repository at this point in the history

  18. Turned off timing

    @dellaert @jlblancoc
    dellaert authored and jlblancoc committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    005b30a View commit details
    Browse the repository at this point in the history

  19. Unstable will not be built or tested in Debug mode: takes too long.

    @dellaert @jlblancoc
    dellaert authored and jlblancoc committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    17642a6 View commit details
    Browse the repository at this point in the history

  20. fix warning 

    "const" ignored in this return type
    @jlblancoc
    jlblancoc committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    6e488db View commit details
    Browse the repository at this point in the history

  21. fix unused parameter warning

    @jlblancoc
    jlblancoc committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    b538f3b View commit details
    Browse the repository at this point in the history

  22. Refactor build flags via CMake target properties 

    Also:
- Allow users to edit cmake target build options in the cache variables.
- We had to add project() commands for  gtsam and gtsam_unstable,
the PROJECT_SOURCE_DIR changed, but the root GTSAM_SOURCE_DIR instead.
- Ensure use of standard C++11 (no extensions)
    @jlblancoc
    jlblancoc committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    8efca6a View commit details
    Browse the repository at this point in the history