Wrap upgrade #525
Merged
Wrap upgrade #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
314b121fd Merge pull request #6 from varunagrawal/feature/pybind-upgrade 5e49bb867 Merge commit '62e790da1cc53cb9910ac5271a3514d88562bdce' into feature/docstring 62e790da1 Squashed 'pybind11/' changes from 441e777..d3c999c e51526702 Merge pull request #5 from varunagrawal/feature/docstring f503ddb2d document use_boost 2bb7158fc complete arguments documentation for pybind_wrap function git-subtree-dir: wrap git-subtree-split: 314b121fd4017338a3a6833728cd646d8ff5be12
varunagrawal
added
python
|
I'm going to merge this and then investigate the build issues. It seems to be on Github's end from what I can glean. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perform a subtree update of wrap.
Motivation
Pybind11 had a relative submodule which even though we didn't use, would cause errors in Github Actions due to the way the checkout action is set up.
After raising this issue with the folks at Pybind11, they agreed it was problematic and updated the codebase to not have the submodule anymore. This PR adds in those changes.
tl;dr Pybind11 made some updates, so we updated it too so Actions doesn't complain.