Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TranslationRecovery Fixes #527

Merged
merged 1 commit into from
Sep 18, 2020
Merged

TranslationRecovery Fixes #527

merged 1 commit into from
Sep 18, 2020

Conversation

varunagrawal
Copy link
Collaborator

  1. Make SharedNoiseModel as optional parameter.
  2. Remove hardcoded verbosity in constructor.
  3. Make test silent.

@varunagrawal varunagrawal self-assigned this Sep 18, 2020
@varunagrawal varunagrawal added enhancement Improvement to GTSAM quick-review Quick and easy PR to review labels Sep 18, 2020
akshay-krishnan
akshay-krishnan approved these changes Sep 18, 2020
View reviewed changes
Copy link
Contributor

@akshay-krishnan akshay-krishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fixes!

@varunagrawal varunagrawal merged commit 076ef20 into develop Sep 18, 2020
@varunagrawal varunagrawal deleted the fix/translation-recovery branch September 18, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshay-krishnan akshay-krishnan akshay-krishnan approved these changes

@dellaert dellaert Awaiting requested review from dellaert

Assignees

@varunagrawal varunagrawal

Labels
enhancement Improvement to GTSAM quick-review Quick and easy PR to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varunagrawal @akshay-krishnan