Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Point3 mean to throw an exception when input size=0 . #542

Merged
merged 4 commits into from
Sep 29, 2020
Merged

Point3 mean to throw an exception when input size=0 . #542

merged 4 commits into from
Sep 29, 2020

Conversation

Alexma3312
Copy link
Contributor

@Alexma3312 Alexma3312 commented Sep 29, 2020 •
edited
Loading

#464 follow up.
A simple fix to throw an exception when the input size equals to zero in the Point3 mean functions. @jlblancoc

@Alexma3312 Alexma3312 changed the title Point3 mean to throw an exception when n=0 . Point3 mean to throw an exception when input size=0 . Sep 29, 2020
varunagrawal
varunagrawal approved these changes Sep 29, 2020
View reviewed changes
Copy link
Collaborator

@varunagrawal varunagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for a minor comment.

gtsam/geometry/Point3.cpp Outdated Show resolved Hide resolved
gtsam/geometry/Point3.h Outdated Show resolved Hide resolved
@varunagrawal varunagrawal added the enhancement Improvement to GTSAM label Sep 29, 2020
@dellaert dellaert merged commit 6fdf39d into borglab:develop Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dellaert dellaert dellaert approved these changes

@varunagrawal varunagrawal varunagrawal approved these changes

Assignees
No one assigned
Labels
enhancement Improvement to GTSAM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alexma3312 @varunagrawal @dellaert