Check for MEX Compiler #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
varunagrawal
commented
Oct 2, 2020
varunagrawal
commented
- Check if mex compiler exists for Matlab wrapper.
- Formatting and restructuring.
varunagrawal
added
matlab
ProfFan
reviewed
Oct 3, 2020
CMakeLists.txt
Outdated
| set(CURRENT_POSTFIX ${CMAKE_${CMAKE_BUILD_TYPE_UPPER}_POSTFIX}) | ||
| endif() | ||
| if(GTSAM_INSTALL_MATLAB_TOOLBOX) | ||
| find_package(Matlab COMPONENTS MEX_COMPILER REQUIRED) |
There was a problem hiding this comment.
I think you should probably remove the relevant code in cmake/GtsamMatlabWrap?
There was a problem hiding this comment.
I don't think there is any related code in GtsamMatlabWrap? I may be wrong though. My understanding is that the code in GtsamMatlabWrap is primarily for wrapping and I didn't want to mess with it for minor things.
|
Thanks for the recommendation @ProfFan. I've reworked this PR to be a lot better. |
|
@ProfFan gentle reminder. |
|
@varunagrawal Sorry I don't have capacity for this now, if you have tested on both Linux and Windows it's good I think. |
|
@ProfFan cool. Can you please approve this PR then? If any issues are raised for the Matlab wrapper, just assign them to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.