Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github Actions Environment Files #587

Merged
merged 5 commits into from
Nov 12, 2020
Merged

Github Actions Environment Files #587

merged 5 commits into from
Nov 12, 2020

Conversation

varunagrawal
Copy link
Collaborator

As per the new security directive, this PR updates all the set-env calls to instead use the new environment files feature.

@varunagrawal varunagrawal added the ci Related to the Continuous Integration pipeline label Nov 8, 2020
@varunagrawal varunagrawal requested a review from ProfFan November 8, 2020 19:49
@varunagrawal varunagrawal self-assigned this Nov 8, 2020
@varunagrawal varunagrawal added easy-fix Quick and easy to fix quick-review Quick and easy PR to review labels Nov 9, 2020
swarrier246
swarrier246 approved these changes Nov 11, 2020
View reviewed changes
Copy link
Contributor

@swarrier246 swarrier246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@varunagrawal varunagrawal added the high-priority Need this done quickly label Nov 12, 2020
@varunagrawal
Copy link
Collaborator Author

Github Actions has removed Boost 1.69 from its Ubuntu 18.04 image as per this announcement. Updated the PR to use Boost 1.72.

@varunagrawal varunagrawal merged commit d8d0cec into develop Nov 12, 2020
@varunagrawal varunagrawal deleted the fix/github-env-files branch November 12, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swarrier246 swarrier246 swarrier246 approved these changes

@ProfFan ProfFan Awaiting requested review from ProfFan

@johnwlambert johnwlambert Awaiting requested review from johnwlambert

@dellaert dellaert Awaiting requested review from dellaert

Assignees

@varunagrawal varunagrawal

Labels
ci Related to the Continuous Integration pipeline easy-fix Quick and easy to fix high-priority Need this done quickly quick-review Quick and easy PR to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varunagrawal @swarrier246