Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gnc #617

Merged
merged 45 commits into from
Jan 4, 2021
Merged

Gnc #617

merged 45 commits into from
Jan 4, 2021

Commits on Nov 25, 2020

  1. Initial design

    @dellaert
    dellaert committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    7e29944 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2020

  1. starting to create test and code for gncParams

    lcarlone committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    b5d06b5 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2020

  1. added equals in NonlinearOptimizerParams

    lcarlone committed Nov 27, 2020
    Configuration menu
    Copy the full SHA
    ff40590 View commit details
    Browse the repository at this point in the history

  2. params parsed correctly

    lcarlone committed Nov 27, 2020
    Configuration menu
    Copy the full SHA
    90dd2c7 View commit details
    Browse the repository at this point in the history

  3. added gnc loop

    lcarlone committed Nov 27, 2020
    Configuration menu
    Copy the full SHA
    f897fa8 View commit details
    Browse the repository at this point in the history

  4. now we have very cool tests!

    lcarlone committed Nov 27, 2020
    Configuration menu
    Copy the full SHA
    a33c50f View commit details
    Browse the repository at this point in the history

  5. 2 tests to go

    lcarlone committed Nov 27, 2020
    Configuration menu
    Copy the full SHA
    5222599 View commit details
    Browse the repository at this point in the history

  6. simplified small test to make it more understandable

    lcarlone committed Nov 27, 2020
    Configuration menu
    Copy the full SHA
    7c22c2c View commit details
    Browse the repository at this point in the history

  7. 1 test to go

    lcarlone committed Nov 27, 2020
    Configuration menu
    Copy the full SHA
    0f07251 View commit details
    Browse the repository at this point in the history

  8. stuck on conversion of noise model

    lcarlone committed Nov 27, 2020
    Configuration menu
    Copy the full SHA
    e991880 View commit details
    Browse the repository at this point in the history

  9. finally I have a way to properly change the noise model!

    lcarlone committed Nov 27, 2020
    Configuration menu
    Copy the full SHA
    5db6894 View commit details
    Browse the repository at this point in the history

  10. working on make graph

    lcarlone committed Nov 27, 2020
    Configuration menu
    Copy the full SHA
    7ce0641 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2020

  1. new constructor test which gets rid of robust loss now passes!

    lcarlone committed Nov 28, 2020
    Configuration menu
    Copy the full SHA
    556fa83 View commit details
    Browse the repository at this point in the history

  2. yay! only the final monster to go!

    lcarlone committed Nov 28, 2020
    Configuration menu
    Copy the full SHA
    9e3263f View commit details
    Browse the repository at this point in the history

  3. added verbosity

    lcarlone committed Nov 28, 2020
    Configuration menu
    Copy the full SHA
    dab0090 View commit details
    Browse the repository at this point in the history

  4. ladies and gents... GNC!

    lcarlone committed Nov 28, 2020
    Configuration menu
    Copy the full SHA
    ef47741 View commit details
    Browse the repository at this point in the history

  5. added functionality to fix weights

    lcarlone committed Nov 28, 2020
    Configuration menu
    Copy the full SHA
    c4644a0 View commit details
    Browse the repository at this point in the history

  6. correct formatting

    lcarlone committed Nov 28, 2020
    Configuration menu
    Copy the full SHA
    7699f04 View commit details
    Browse the repository at this point in the history

  7. done - PGO works like a charm!

    lcarlone committed Nov 28, 2020
    Configuration menu
    Copy the full SHA
    786d4bb View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2020

  1. moved class to .h

    lcarlone committed Dec 5, 2020
    Configuration menu
    Copy the full SHA
    fcf2d31 View commit details
    Browse the repository at this point in the history

  2. added comments

    lcarlone committed Dec 5, 2020
    Configuration menu
    Copy the full SHA
    db1a366 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2020

  1. fix comment

    @jingnanshi
    jingnanshi committed Dec 6, 2020
    Configuration menu
    Copy the full SHA
    af069ab View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2020

  1. TLS wip

    @jingnanshi
    jingnanshi committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    47775a7 View commit details
    Browse the repository at this point in the history

  2. tls done except unit tests

    @jingnanshi
    jingnanshi committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    9903fb9 View commit details
    Browse the repository at this point in the history

  3. minor fix

    @jingnanshi
    jingnanshi committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    d85d9c6 View commit details
    Browse the repository at this point in the history

  4. fix scoping

    @jingnanshi
    jingnanshi committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    58e49fc View commit details
    Browse the repository at this point in the history

  5. mu initialization test & minor formatting fixes

    @jingnanshi
    jingnanshi committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    d0a81f8 View commit details
    Browse the repository at this point in the history

  6. mu update test 

    Separated GM & TLS case
make sure the mu set size is explicitly stated (does not depend on default values)
    @jingnanshi
    jingnanshi committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    9caa0d1 View commit details
    Browse the repository at this point in the history

  7. correctly check relative difference between mu valus at consecutive i… 

    …terations
    @jingnanshi
    jingnanshi committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    428d17a View commit details
    Browse the repository at this point in the history

  8. test fix

    @jingnanshi
    jingnanshi committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    594f63d View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2020

  1. more unit tests

    @jingnanshi
    jingnanshi committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    398c013 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2020

  1. templating on params is still problematic

    lcarlone committed Dec 22, 2020
    Configuration menu
    Copy the full SHA
    75bd3dc View commit details
    Browse the repository at this point in the history

  2. finally fixed the typedef

    lcarlone committed Dec 22, 2020
    Configuration menu
    Copy the full SHA
    7efd5cc View commit details
    Browse the repository at this point in the history

  3. fixed templating, added a strict unit test on inlier threshold

    lcarlone committed Dec 22, 2020
    Configuration menu
    Copy the full SHA
    0e09f01 View commit details
    Browse the repository at this point in the history

  4. made function name less ambiguous, added more comments on inlierThres… 

    …hold
    lcarlone committed Dec 22, 2020
    Configuration menu
    Copy the full SHA
    cd82a56 View commit details
    Browse the repository at this point in the history

  5. Fix TLS convergence check

    @jingnanshi
    jingnanshi committed Dec 22, 2020
    Configuration menu
    Copy the full SHA
    046db87 View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2020

  1. update function name

    @jingnanshi
    jingnanshi committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    be5d3d2 View commit details
    Browse the repository at this point in the history

  2. fix test

    @jingnanshi
    jingnanshi committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    c571744 View commit details
    Browse the repository at this point in the history

Commits on Dec 24, 2020

  1. - fixed stopping conditions 

    - handled degenerate case in mu initialization
- set TLS as default
- added more unit tests
    lcarlone committed Dec 24, 2020
    Configuration menu
    Copy the full SHA
    dc5c769 View commit details
    Browse the repository at this point in the history

  2. minor fixes

    @jingnanshi
    jingnanshi committed Dec 24, 2020
    Configuration menu
    Copy the full SHA
    92ed225 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2020

  1. moved GncParams to separate file, addressing comments by Frank, 1/n

    lcarlone committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    06dfeb7 View commit details
    Browse the repository at this point in the history

  2. renamed enum

    lcarlone committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    eea5276 View commit details
    Browse the repository at this point in the history

  3. addressed all except 2 comments by Frank. waiting for inputs on the 2… 

    … outstanding issues
    lcarlone committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    dfdd206 View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2020

  1. moved gncLossType outside params

    lcarlone committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    2467238 View commit details
    Browse the repository at this point in the history

  2. addressed final comments by Frank

    lcarlone committed Dec 30, 2020
    Configuration menu
    Copy the full SHA
    248eec8 View commit details
    Browse the repository at this point in the history