Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrapper Update #750

Merged
merged 3 commits into from
Apr 21, 2021
Merged

Wrapper Update #750

merged 3 commits into from
Apr 21, 2021

Conversation

varunagrawal
Copy link
Collaborator

@varunagrawal varunagrawal commented Apr 21, 2021 •
edited
Loading

  1. Fix global variable assignment.
  2. Wrap enums defined inside classes.
  3. Added default values for print() so that __repr__ works.

@varunagrawal
Squashed 'wrap/' changes from b2144a712..0124bcc45
4a2d322 
0124bcc45 Merge pull request #97 from borglab/fix/enums-in-classes
f818f94d6 Merge pull request #98 from borglab/fix/global-variables
ccc84d3bc some cleanup
edf141eb7 assign global variable value correctly
ad1d6d241 define class instances for enums
963bfdadd prepend full class namespace
e9342a43f fix enums defined in classes
35311571b Merge pull request #88 from borglab/doc/git_subtree
b9d2ec972 Address review comments
1f7651402 update `update` documentation to not require manual subtree merge command
df834d96b capitalization
36dabbef1 git subtree documentation

git-subtree-dir: wrap
git-subtree-split: 0124bcc45fa83e295750438fbfd11ddface5466f
@varunagrawal
Merging 'master' into 'wrap'
b53657a
@varunagrawal varunagrawal added python Related to python wrapper matlab Related to MATLAB wrapper labels Apr 21, 2021
@varunagrawal varunagrawal self-assigned this Apr 21, 2021
@dellaert
Copy link
Member

Description is meaningless ;-) What is the change to wrap that is merged here?

@dellaert
Copy link
Member

PR comments are docs

dellaert
dellaert approved these changes Apr 21, 2021
View reviewed changes
Copy link
Member

@dellaert dellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, as print was broken in python. Merge after CI suceeds.

@dellaert dellaert merged commit 301f7fe into develop Apr 21, 2021
@dellaert dellaert deleted the feature/wrap-update branch April 21, 2021 12:33
@gchenfc gchenfc mentioned this pull request Apr 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dellaert dellaert dellaert approved these changes

Assignees

@varunagrawal varunagrawal

Labels
matlab Related to MATLAB wrapper python Related to python wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varunagrawal @dellaert